linux-kernel - Re: [PATCH 4.19 84/90] cfg80211: fix memory leak of wiphy device name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190625215135.GA32248@amd>
Date:   Tue, 25 Jun 2019 23:51:36 +0200
From:   Pavel Machek <pavel@...x.de>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        syzbot+7fddca22578bc67c3fe4@...kaller.appspotmail.com,
        Eric Biggers <ebiggers@...gle.com>,
        Johannes Berg <johannes.berg@...el.com>
Subject: Re: [PATCH 4.19 84/90] cfg80211: fix memory leak of wiphy device name

Hi!

> From: Eric Biggers <ebiggers@...gle.com>
> 
> commit 4f488fbca2a86cc7714a128952eead92cac279ab upstream.
> 
> In wiphy_new_nm(), if an error occurs after dev_set_name() and
> device_initialize() have already been called, it's necessary to call
> put_device() (via wiphy_free()) to avoid a memory leak.
....
> --- a/net/wireless/core.c
> +++ b/net/wireless/core.c
> @@ -498,7 +498,7 @@ use_default_name:
>  				   &rdev->rfkill_ops, rdev);
>  
>  	if (!rdev->rfkill) {
> -		kfree(rdev);
> +		wiphy_free(&rdev->wiphy);
>  		return NULL;
>  	}

Is kfree(rdev) still neccessary?
drivers/net/wireless/marvell/libertas/cfg.c seems to suggest so.

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)