linux-kernel - Re: [PATCH v6 7/8] dynamic_debug: add asm-generic implementation for DYNAMIC_DEBUG_RELATIVE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 25 Jun 2019 15:18:34 -0700
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     Rasmus Villemoes <linux@...musvillemoes.dk>
Cc:     Ingo Molnar <mingo@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Jason Baron <jbaron@...mai.com>,
        Nathan Chancellor <natechancellor@...il.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6 7/8] dynamic_debug: add asm-generic implementation for DYNAMIC_DEBUG_RELATIVE_POINTERS

On Mon, Jun 24, 2019 at 11:35 PM Rasmus Villemoes
<linux@...musvillemoes.dk> wrote:
>
> On 24/06/2019 23.53, Nick Desaulniers wrote:
> > On Thu, Jun 20, 2019 at 1:46 PM Rasmus Villemoes
> > <linux@...musvillemoes.dk> wrote:
> >> Well, apart from booting, I've mostly just tested that the debugfs
> >> control file is identical before and after enabling relative pointers,
> >
> > mainline x86_64 defconfig+CONFIG_DYNAMIC_DEBUG
> > $ cat /dfs/dynamic_debug/control  | wc -l
> > 2488
> >
> >
> > mainline x86_64 defconfig+CONFIG_DYNAMIC_DEBUG+this patch series
> > $ cat /dfs/dynamic_debug/control  | wc -l
> > 2486
> >
> > (seems like maybe 2 are missing?  Let me try to collect a diff. Maybe
> > 2 were removed in this series?)
>
> Hm, no pr_debugs should have been added or removed. Perhaps you have a
> slightly different set of modules loaded? Otherwise there's something
> odd going on, and a diff would be really nice. It's possible that the
> order of the lines are different, so you may have to sort them to get a
> meaningful diff. (A diff is nice extra sanity check even if the line
> count matches, of course).

You can fetch my logs from the latest commit to this dummy branch:
https://github.com/ClangBuiltLinux/linux/commit/90096d926aaf94eb84584a4418fde7c8d42dddea

Looking at `meld wo_patches.txt w_patches.txt`, it looks like:
1. line numbers in some translation units are adjusted.  maybe this is
intentional?
2. pci_pm_suspend_noirq seems to exist twice(?) before your patches, once after
3. xhci_urb_enqueue seems to exist three times before your patches, twice after

-- 
Thanks,
~Nick Desaulniers