linux-kernel - Re: [v3 PATCH 3/4] mm: shrinker: make shrinker not depend on memcg kmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3d099616-2fc6-fa4e-377c-2f406e3302f9@linux.alibaba.com>
Date:   Tue, 25 Jun 2019 15:30:13 -0700
From:   Yang Shi <yang.shi@...ux.alibaba.com>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     ktkhai@...tuozzo.com, kirill.shutemov@...ux.intel.com,
        hannes@...xchg.org, mhocko@...e.com, hughd@...gle.com,
        shakeelb@...gle.com, rientjes@...gle.com, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [v3 PATCH 3/4] mm: shrinker: make shrinker not depend on memcg
 kmem



On 6/25/19 3:14 PM, Andrew Morton wrote:
> On Thu, 13 Jun 2019 05:56:48 +0800 Yang Shi <yang.shi@...ux.alibaba.com> wrote:
>
>> Currently shrinker is just allocated and can work when memcg kmem is
>> enabled.  But, THP deferred split shrinker is not slab shrinker, it
>> doesn't make too much sense to have such shrinker depend on memcg kmem.
>> It should be able to reclaim THP even though memcg kmem is disabled.
>>
>> Introduce a new shrinker flag, SHRINKER_NONSLAB, for non-slab shrinker.
>> When memcg kmem is disabled, just such shrinkers can be called in
>> shrinking memcg slab.
> This causes a couple of compile errors with an allnoconfig build.
> Please fix that and test any other Kconfig combinations which might
> trip things up.

I just tested !CONFIG_TRANSPARENT_HUGEPAGE, but I didn't test 
!CONFIG_MEMCG. It looks we need keep the code for !CONFIG_MEMCG, will 
post the corrected patches soon.