linux-kernel - Re: [PATCH] clk: qcom: Fix -Wunused-const-variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190625224955.B6D5F20645@mail.kernel.org>
Date:   Tue, 25 Jun 2019 15:49:54 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Nathan Huckleberry <nhuck@...gle.com>, agross@...nel.org,
        david.brown@...aro.org, mturquette@...libre.com
Cc:     linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Nathan Huckleberry <nhuck@...gle.com>,
        clang-built-linux@...glegroups.com,
        Nathan Chancellor <natechancellor@...il.com>
Subject: Re: [PATCH] clk: qcom: Fix -Wunused-const-variable

Quoting Nathan Huckleberry (2019-06-11 14:11:34)
> Clang produces the following warning
> 
> drivers/clk/qcom/gcc-msm8996.c:133:32: warning: unused variable
> 'gcc_xo_gpll0_gpll2_gpll3_gpll0_early_div_map' [-Wunused-const-variable]
> static const struct
> parent_map gcc_xo_gpll0_gpll2_gpll3_gpll0_early_div_map[] =
> { ^drivers/clk/qcom/gcc-msm8996.c:141:27: warning: unused variable
> 'gcc_xo_gpll0_gpll2_gpll3_gpll0_early_div' [-Wunused-const-variable] static
> const char * const gcc_xo_gpll0_gpll2_gpll3_gpll0_early_div[] = { ^
> drivers/clk/qcom/gcc-msm8996.c:187:32: warning: unused variable
> 'gcc_xo_gpll0_gpll2_gpll3_gpll1_gpll4_gpll0_early_div_map'
> [-Wunused-const-variable] static const struct parent_map
> gcc_xo_gpll0_gpll2_gpll3_gpll1_gpll4_gpll0_early_div_map[] = { ^
> drivers/clk/qcom/gcc-msm8996.c:197:27: warning: unused variable
> 'gcc_xo_gpll0_gpll2_gpll3_gpll1_gpll4_gpll0_early_div'
> [-Wunused-const-variable] static const char * const
> gcc_xo_gpll0_gpll2_gpll3_gpll1_gpll4_gpll0_early_div[] = {
> 
> It looks like these were never used.
> 
> Fixes: b1e010c0730a ("clk: qcom: Add MSM8996 Global Clock Control (GCC) driver")
> Cc: clang-built-linux@...glegroups.com
> Link: https://github.com/ClangBuiltLinux/linux/issues/518
> Suggested-by: Nathan Chancellor <natechancellor@...il.com>
> Signed-off-by: Nathan Huckleberry <nhuck@...gle.com>
> ---

Applied to clk-next