linux-kernel - Re: [PATCH v2 0/3] ceph: don't NULL terminate virtual xattr values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190625185039.08fa5a4f@gandalf.local.home>
Date:   Tue, 25 Jun 2019 18:50:39 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Jeff Layton <jlayton@...nel.org>
Cc:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        ceph-devel <ceph-devel@...r.kernel.org>,
        Ilya Dryomov <idryomov@...il.com>, Zheng Yan <zyan@...hat.com>,
        sage@...hat.com, agruenba@...hat.com,
        Joe Perches <joe@...ches.com>, Petr Mladek <pmladek@...e.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>
Subject: Re: [PATCH v2 0/3] ceph: don't NULL terminate virtual xattr values

On Thu, 20 Jun 2019 09:54:13 -0400
Jeff Layton <jlayton@...nel.org> wrote:

> > snprintf() to a temporary buffer, and memcpy() to the final destination.
> > These are all fairly small buffers (most are single integer values),
> > so the overhead should be minimal, right?
> >   
> 
> Yeah. I was trying to avoid having to deal with a second buffer, but
> this is not a performance-critical codepath, so maybe that's the best
> option.

Yes, this looks like the better solution than adding a new library
function for other people to (ab)use.

-- Steve