linux-kernel - Re: [PATCH v2] arm64: dts: qcom: msm8996: Rename smmu nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 25 Jun 2019 13:44:51 +0530
From:   Vivek Gautam <vivek.gautam@...eaurora.org>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     Andy Gross <agross@...nel.org>,
        David Brown <david.brown@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] arm64: dts: qcom: msm8996: Rename smmu nodes

On Wed, Jun 19, 2019 at 5:46 AM Bjorn Andersson
<bjorn.andersson@...aro.org> wrote:
>
> Node names shouldn't include a vendor prefix and should whenever
> possible use a generic identifier. Resolve this by renaming the smmu
> nodes "iommu".

The bindings too say so :)
Reviewed-by: Vivek Gautam <vivek.gautam@...eaurora.org>

>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@...aro.org>
> ---
>
> Changes since v1:
> - Updated commit message to talk about vendor prefix rather than qcom,
>
>  arch/arm64/boot/dts/qcom/msm8996.dtsi | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> index 2ecd9d775d61..c934e00434c7 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> @@ -1163,7 +1163,7 @@
>                         };
>                 };
>
> -               vfe_smmu: arm,smmu@...000 {
> +               vfe_smmu: iommu@...000 {
>                         compatible = "qcom,msm8996-smmu-v2", "qcom,smmu-v2";
>                         reg = <0xda0000 0x10000>;
>
> @@ -1314,7 +1314,7 @@
>                         };
>                 };
>
> -               adreno_smmu: arm,smmu@...000 {
> +               adreno_smmu: iommu@...000 {
>                         compatible = "qcom,msm8996-smmu-v2", "qcom,smmu-v2";
>                         reg = <0xb40000 0x10000>;
>
> @@ -1331,7 +1331,7 @@
>                         power-domains = <&mmcc GPU_GDSC>;
>                 };
>
> -               mdp_smmu: arm,smmu@...000 {
> +               mdp_smmu: iommu@...000 {
>                         compatible = "qcom,msm8996-smmu-v2", "qcom,smmu-v2";
>                         reg = <0xd00000 0x10000>;
>
> @@ -1347,7 +1347,7 @@
>                         power-domains = <&mmcc MDSS_GDSC>;
>                 };
>
> -               lpass_q6_smmu: arm,smmu-lpass_q6@...0000 {
> +               lpass_q6_smmu: iommu@...0000 {
>                         compatible = "qcom,msm8996-smmu-v2", "qcom,smmu-v2";
>                         reg = <0x1600000 0x20000>;
>                         #iommu-cells = <1>;
> --
> 2.18.0
>


-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation