linux-kernel - Re: [PATCH] nios2: remove pointless second entry for CONFIG_TRACE_IRQFLAGS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1561427374.3131.2.camel@intel.com>
Date:   Tue, 25 Jun 2019 09:49:34 +0800
From:   Ley Foon Tan <ley.foon.tan@...el.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Ley Foon Tan <lftan@...era.com>,
        nios2-dev@...ts.rocketboards.org
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] nios2: remove pointless second entry for
 CONFIG_TRACE_IRQFLAGS_SUPPORT

On Sun, 2019-06-23 at 23:13 +0900, Masahiro Yamada wrote:
> On Sun, May 12, 2019 at 10:16 PM Masahiro Yamada
> <yamada.masahiro@...ionext.com> wrote:
> > 
> > 
> > Strangely enough, NIOS2 defines TRACE_IRQFLAGS_SUPPORT twice
> > with different values, which is pointless and confusing.
> > 
> > [1] arch/nios2/Kconfig
> > 
> >   config TRACE_IRQFLAGS_SUPPORT
> >           def_bool n
> > 
> > [2] arch/nios2/Kconfig.debug
> > 
> >   config TRACE_IRQFLAGS_SUPPORT
> >           def_bool y
> > 
> > [1] is included before [2]. In the Kconfig syntax, the first one
> > is effective. So, TRACE_IRQFLAGS_SUPPORT is always 'n'.
> > 
> > The second define in arch/nios2/Kconfig.debug is dead code.
> > 
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> > ---
> Ping.
> 
> 
Acked-by: Ley Foon Tan <ley.foon.tan@...el.com>
Will integrate to next kernel version.
Thanks.

> > 
> >  arch/nios2/Kconfig.debug | 3 ---
> >  1 file changed, 3 deletions(-)
> > 
> > diff --git a/arch/nios2/Kconfig.debug b/arch/nios2/Kconfig.debug
> > index f1da8a7..a8bc06e 100644
> > --- a/arch/nios2/Kconfig.debug
> > +++ b/arch/nios2/Kconfig.debug
> > @@ -1,8 +1,5 @@
> >  # SPDX-License-Identifier: GPL-2.0
> > 
> > -config TRACE_IRQFLAGS_SUPPORT
> > -       def_bool y
> > -
> >  config EARLY_PRINTK
> >         bool "Activate early kernel debugging"
> >         default y
> > --
> > 2.7.4
> > 
> 
> --
> Best Regards
> Masahiro Yamada
> 
> ________________________________

Regards
Ley Foon