linux-kernel - Re: [PATCH 11/12] iomap: move the xfs writeback code to iomap.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190625100810.GH1462@lst.de>
Date:   Tue, 25 Jun 2019 12:08:10 +0200
From:   Christoph Hellwig <hch@....de>
To:     "Darrick J. Wong" <darrick.wong@...cle.com>
Cc:     Christoph Hellwig <hch@....de>,
        Damien Le Moal <Damien.LeMoal@....com>,
        Andreas Gruenbacher <agruenba@...hat.com>,
        linux-xfs@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 11/12] iomap: move the xfs writeback code to iomap.c

On Mon, Jun 24, 2019 at 08:46:01AM -0700, Darrick J. Wong wrote:
> This looks like a straight code copy from fs/xfs/ into fs/iomap.c.
> That's fine with me, but seeing as this file is now ~2700 lines long,
> perhaps we should break this up among major functional lines?
> 
> Looking at fs/iomap.c, I see...
> 
>  * Basic iomap iterator functions (~40 lines)
>  * Page cache management (readpage*, write, mkwrite) (~860 lines)
>  * Zeroing (~80 lines)
>  * FIEMAP and seek hole / seek data (~300 lines)
>  * directio (~500 lines)
>  * swapfiles (~170 lines)
>  * and now, page cache writeback (~520 lines)
> 
> If I have spare time this week (ha ha) I'll see if I can break all this
> up (as a separate patch series), so for this:

Meh.  Not sure I'm a fan of too fine grained splits like the one
above.  And ~3k lines is still pretty manageable.  But yes, once it
grows むore it might be worth splitting a bit.