linux-kernel - Re: [PATCH] arm64: dts: imx8mq: Init rates and parents configs for clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <VI1PR04MB50550ACBAEA73FD7B5A97DD8EEE30@VI1PR04MB5055.eurprd04.prod.outlook.com>
Date:   Tue, 25 Jun 2019 14:22:00 +0000
From:   Leonard Crestez <leonard.crestez@....com>
To:     Abel Vesa <abel.vesa@....com>, Shawn Guo <shawnguo@...nel.org>,
        Fabio Estevam <fabio.estevam@....com>,
        Stephen Boyd <sboyd@...nel.org>, Jacky Bai <ping.bai@....com>
CC:     Rob Herring <robh@...nel.org>, Mark Rutland <mark.rutland@....com>,
        Sascha Hauer <kernel@...gutronix.de>,
        Anson Huang <anson.huang@....com>,
        dl-linux-imx <linux-imx@....com>,
        Lucas Stach <l.stach@...gutronix.de>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Andrey Smirnov <andrew.smirnov@...il.com>
Subject: Re: [PATCH] arm64: dts: imx8mq: Init rates and parents configs for
 clocks

On 25.06.2019 15:51, Abel Vesa wrote:
> Add the initial configuration for clocks that need default parent and rate
> setting. This is based on the vendor tree clock provider parents and rates
> configuration except this is doing the setup in dts rather then using clock
> consumer API in a clock provider driver.
> 
> Signed-off-by: Abel Vesa <abel.vesa@....com>
> ---
>   arch/arm64/boot/dts/freescale/imx8mq.dtsi | 34 +++++++++++++++++++++++++++++++
>   1 file changed, 34 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index d09b808..e0abe02 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -489,6 +489,40 @@

> +					<&clk IMX8MQ_CLK_PCIE1_CTRL>,
> +					<&clk IMX8MQ_CLK_PCIE1_PHY>,
> +					<&clk IMX8MQ_CLK_PCIE2_CTRL>,
> +					<&clk IMX8MQ_CLK_PCIE2_PHY>,
> +					<&clk IMX8MQ_CLK_CSI1_CORE>,
> +					<&clk IMX8MQ_CLK_CSI1_PHY_REF>,
> +					<&clk IMX8MQ_CLK_CSI1_ESC>,
> +					<&clk IMX8MQ_CLK_CSI2_CORE>,
> +					<&clk IMX8MQ_CLK_CSI2_PHY_REF>,
> +					<&clk IMX8MQ_CLK_CSI2_ESC>;

This stuff (and NAND) looks like it would belong to device nodes instead.

The rest seem fine though I'm not sure why exactly those clks are 
adjusted in vendor tree.

--
Regards,
Leonard