linux-kernel - Re: [PATCH] arm64: Kconfig: Enable NODES_SPAN_OTHER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8fcd11c8-13d2-f21a-f6c0-c16cff11803b@os.amperecomputing.com>
Date:   Tue, 25 Jun 2019 14:55:53 +0000
From:   Hoan Tran OS <hoan@...amperecomputing.com>
To:     Will Deacon <will@...nel.org>
CC:     Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>,
        Open Source Submission <patches@...erecomputing.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] arm64: Kconfig: Enable NODES_SPAN_OTHER_NODES config for
 NUMA

Hi Will,

On 6/25/19 3:12 AM, Will Deacon wrote:
> On Mon, Jun 24, 2019 at 02:38:28PM +0000, Hoan Tran OS wrote:
>> Some NUMA nodes have memory ranges that span other nodes.
>> Even though a pfn is valid and between a node's start and end pfns,
>> it may not reside on that node.
>>
>> This patch enables NODES_SPAN_OTHER_NODES config for NUMA to support
>> this type of NUMA layout.
>>
>> Signed-off-by: Hoan Tran <Hoan@...amperecomputing.com>
>> ---
>>   arch/arm64/Kconfig | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
>> index 697ea05..21fc168 100644
>> --- a/arch/arm64/Kconfig
>> +++ b/arch/arm64/Kconfig
>> @@ -873,6 +873,13 @@ config NEED_PER_CPU_EMBED_FIRST_CHUNK
>>   config HOLES_IN_ZONE
>>   	def_bool y
>>   
>> +# Some NUMA nodes have memory ranges that span other nodes.
>> +# Even though a pfn is valid and between a node's start and end pfns,
>> +# it may not reside on that node.
>> +config NODES_SPAN_OTHER_NODES
>> +	def_bool y
>> +	depends on ACPI_NUMA
> 
> How come this is specific to ACPI?

I referred to x86 config. Beside of that, I only can test on the system 
with ACPI supported.

> 
> It would be nice if this was the default, given that only ia64, mips and
> sh appear to be the only NUMA-capable architectures which don't have it.
> In other words, replace the #ifdef CONFIG_NODES_SPAN_OTHER_NODES in
> mm/page_alloc.c with #ifdef CONFIG_NUMA.

Agreed, let me send another patch as your suggestion.

Thanks
Hoan

> Will
>