linux-kernel - Re: "arm64: vdso: Substitute gettimeofday() with C implementation" breaks clang build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKwvOdmCFjunXRbninTdqoDGPNJ6b7npgXLAPYGqFZas5ofNjw@mail.gmail.com>
Date:   Tue, 25 Jun 2019 09:26:51 -0700
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     Vincenzo Frascino <vincenzo.frascino@....com>
Cc:     Qian Cai <cai@....pw>, Thomas Gleixner <tglx@...utronix.de>,
        Will Deacon <will.deacon@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Nathan Chancellor <natechancellor@...il.com>
Subject: Re: "arm64: vdso: Substitute gettimeofday() with C implementation"
 breaks clang build

On Tue, Jun 25, 2019 at 7:54 AM Vincenzo Frascino
<vincenzo.frascino@....com> wrote:
>
> Hi Qian,
>
> ...
>
> >
> > but clang 7.0 is still use in many distros by default, so maybe this commit can
> > be fixed by adding a conditional check to use "small" if clang version < 8.0.
> >
>
> Could you please verify that the patch below works for you?

Should it be checking against CONFIG_CLANG_VERSION, or better yet be
using cc-option macro?
-- 
Thanks,
~Nick Desaulniers