linux-kernel - Re: [PATCH] modules: fix compile error if don't have strict module rwx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190626184322.GB16326@linux-8ccs>
Date:   Wed, 26 Jun 2019 20:43:22 +0200
From:   Jessica Yu <jeyu@...nel.org>
To:     Yang Yingliang <yangyingliang@...wei.com>
Cc:     linux-kernel@...r.kernel.org, peterz@...radead.org,
        namit@...are.com, cj.chengjian@...wei.com, sfr@...b.auug.org.au,
        linux-next@...r.kernel.org
Subject: Re: [PATCH] modules: fix compile error if don't have strict module
 rwx

+++ Yang Yingliang [26/06/19 11:36 +0800]:
>
>
>On 2019/6/26 3:21, Jessica Yu wrote:
>>+++ Yang Yingliang [25/06/19 17:40 +0800]:
>>>If CONFIG_ARCH_HAS_STRICT_MODULE_RWX is not defined,
>>>we need stub for module_enable_nx() and module_enable_x().
>>>
>>>If CONFIG_ARCH_HAS_STRICT_MODULE_RWX is defined, but
>>>CONFIG_STRICT_MODULE_RWX is disabled, we need stub for
>>>module_enable_nx.
>>>
>>>Move frob_text() outside of the CONFIG_STRICT_MODULE_RWX,
>>>because it is needed anyway.
>>
>>Maybe include a fixes tag?
>>
>>Fixes: 2eef1399a866 ("modules: fix BUG when load module with rodata=n")
>OK, I will add it in v2.

No need to, I've added the fixes tag and queued it up on modules-next. Thanks!

Jessica