[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <68fea180-c3a4-b7d9-09b6-1d3ddbc89f9d@codeaurora.org>
Date: Thu, 27 Jun 2019 00:32:14 +0530
From: Sai Prakash Ranjan <saiprakash.ranjan@...eaurora.org>
To: Mathieu Poirier <mathieu.poirier@...aro.org>
Cc: Suzuki K Poulose <suzuki.poulose@....com>,
Leo Yan <leo.yan@...aro.org>, Rob Herring <robh+dt@...nel.org>,
devicetree@...r.kernel.org,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
Andy Gross <andy.gross@...aro.org>,
David Brown <david.brown@...aro.org>,
Mark Rutland <mark.rutland@....com>,
Rajendra Nayak <rnayak@...eaurora.org>,
Vivek Gautam <vivek.gautam@...eaurora.org>,
Sibi Sankar <sibis@...eaurora.org>,
linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
linux-arm-msm <linux-arm-msm@...r.kernel.org>
Subject: Re: [PATCHv3 1/1] coresight: Do not default to CPU0 for missing CPU
phandle
Hi Mathieu,
On 6/26/2019 11:11 PM, Mathieu Poirier wrote:
> Hi Sai,
>
> On Sun, 23 Jun 2019 at 21:36, Sai Prakash Ranjan
> <saiprakash.ranjan@...eaurora.org> wrote:
>> diff --git a/drivers/hwtracing/coresight/coresight-platform.c b/drivers/hwtracing/coresight/coresight-platform.c
>> index 3c5ceda8db24..4990da2c13e9 100644
>> --- a/drivers/hwtracing/coresight/coresight-platform.c
>> +++ b/drivers/hwtracing/coresight/coresight-platform.c
>> @@ -159,16 +159,16 @@ static int of_coresight_get_cpu(struct device *dev)
>> struct device_node *dn;
>>
>> if (!dev->of_node)
>> - return 0;
>> + return -ENODEV;
>> +
>> dn = of_parse_phandle(dev->of_node, "cpu", 0);
>> - /* Affinity defaults to CPU0 */
>> if (!dn)
>> - return 0;
>> + return -ENODEV;
>> +
>> cpu = of_cpu_node_to_id(dn);
>> of_node_put(dn);
>>
>> - /* Affinity to CPU0 if no cpu nodes are found */
>> - return (cpu < 0) ? 0 : cpu;
>> + return cpu;
>> }
>
> Function of_coresight_get_cpu() needs to return -ENODEV rather than 0
> when !CONFIG_OF
>
>>
>> /*
>> @@ -734,14 +734,14 @@ static int acpi_coresight_get_cpu(struct device *dev)
>> struct acpi_device *adev = ACPI_COMPANION(dev);
>>
>> if (!adev)
>> - return 0;
>> + return -ENODEV;
>> status = acpi_get_parent(adev->handle, &cpu_handle);
>> if (ACPI_FAILURE(status))
>> - return 0;
>> + return -ENODEV;
>>
>> cpu = acpi_handle_to_logical_cpuid(cpu_handle);
>> if (cpu >= nr_cpu_ids)
>> - return 0;
>> + return -ENODEV;
>> return cpu;
>> }
>>
>
> Same as above, but for !CONFIG_ACPI
>
Have fixed and resent, thanks Mathieu.
-Sai
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
Powered by blists - more mailing lists