linux-kernel - Re: [PATCH -next] nvme-pci: Make nvme_dev_pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190626202311.GB4934@minwooim-desktop>
Date:   Thu, 27 Jun 2019 05:23:11 +0900
From:   Minwoo Im <minwoo.im.dev@...il.com>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     kbusch@...nel.org, axboe@...com, hch@....de, sagi@...mberg.me,
        keith.busch@...el.com, linux-kernel@...r.kernel.org,
        linux-nvme@...ts.infradead.org, Minwoo Im <minwoo.im.dev@...il.com>
Subject: Re: [PATCH -next] nvme-pci: Make nvme_dev_pm_ops static

On 19-06-26 10:09:02, YueHaibing wrote:
> Fix sparse warning:
> 
> drivers/nvme/host/pci.c:2926:25: warning:
>  symbol 'nvme_dev_pm_ops' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/nvme/host/pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index 1893520..f500133 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -2923,7 +2923,7 @@ static int nvme_simple_resume(struct device *dev)
>  	return 0;
>  }
>  
> -const struct dev_pm_ops nvme_dev_pm_ops = {
> +static const struct dev_pm_ops nvme_dev_pm_ops = {
>  	.suspend	= nvme_suspend,
>  	.resume		= nvme_resume,
>  	.freeze		= nvme_simple_suspend,

IMHO, it should be in static.

Reviewed-by: Minwoo Im <minwoo.im.dev@...il.com>