linux-kernel - Re: [PATCH v3 2/2] iio: cros_ec: Extend legacy support to ARM device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=WYg8d8ZHqcH7LWsSXx5-9kNP+nC+eS84=XNdaZi_7_-w@mail.gmail.com>
Date:   Wed, 26 Jun 2019 14:05:02 -0700
From:   Doug Anderson <dianders@...omium.org>
To:     Gwendal Grignou <gwendal@...omium.org>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        Benson Leung <bleung@...omium.org>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Guenter Roeck <groeck@...omium.org>,
        Fabien Lahoudere <fabien.lahoudere@...labora.com>,
        linux-iio <linux-iio@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 2/2] iio: cros_ec: Extend legacy support to ARM device

Hi,

On Mon, Jun 24, 2019 at 3:53 PM Gwendal Grignou <gwendal@...omium.org> wrote:
>
> -static int read_ec_accel_data(struct cros_ec_accel_legacy_state *st,
> -                             unsigned long scan_mask, s16 *data)
> +int cros_ec_accel_legacy_read_cmd(struct iio_dev *indio_dev,
> +                                 unsigned long scan_mask, s16 *data)

As found by 0day (see https://crrev.com/c/1678822), the
cros_ec_accel_legacy_read_cmd() should have been static.

I presume this will cause less confusion if a maintainer just fixes
this up when landing the patch so Gwendal shouldn't send out a new
version to fix it.  ...but if this is not the case then yell!  :-)

-Doug