linux-kernel - Re: [PATCH] arm64: dts: sdm845: Add video nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5d13e479.1c69fb81.dd08b.b1e4@mx.google.com>
Date:   Wed, 26 Jun 2019 14:32:40 -0700
From:   Stephen Boyd <swboyd@...omium.org>
To:     Aniket Masule <amasule@...eaurora.org>, andy.gross@...aro.org,
        david.brown@...aro.org, mark.rutland@....com, robh+dt@...nel.org
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, mgottam@...eaurora.org,
        vgarodia@...eaurora.org, Aniket Masule <amasule@...eaurora.org>
Subject: Re: [PATCH] arm64: dts: sdm845: Add video nodes

Quoting Aniket Masule (2019-06-26 04:54:07)
> This adds video nodes to sdm845 based on the examples
> in the bindings.
> 
> Signed-off-by: Malathi Gottam <mgottam@...eaurora.org>

There should be a From: line with this person's name in the email if
they're the author. Otherwise this sign-off chain doesn't make sense and
it should most likely have a Co-developed-by tag instead.

> Signed-off-by: Aniket Masule <amasule@...eaurora.org>
> ---
>  arch/arm64/boot/dts/qcom/sdm845.dtsi | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index fcb9330..ff94cfa 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -2437,6 +2437,36 @@
>                                 <GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH>;
>                         iommus = <&apps_smmu 0x0040 0x1>;
>                 };
> +
> +               video-codec@...0000 {

This needs to be sorted by address. It doesn't come after 18800000 (the
address of the node above).

> +                       compatible = "qcom,sdm845-venus";
> +                       reg = <0x0aa00000 0xff000>;
> +                       interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;