[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20190626070658.GP2962@vkoul-mobl>
Date: Wed, 26 Jun 2019 12:36:58 +0530
From: Vinod Koul <vkoul@...nel.org>
To: Mathias Nyman <mathias.nyman@...el.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: linux-arm-msm@...r.kernel.org,
Bjorn Andersson <bjorn.andersson@...aro.org>,
Christian Lamparter <chunkeey@...glemail.com>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
Christian Lamparter <chunkeey@...il.com>
Subject: Re: [PATCH v3 1/4] usb: xhci: add firmware loader for uPD720201 and
uPD720202 w/o ROM
On 24-06-19, 11:41, Vinod Koul wrote:
> From: Christian Lamparter <chunkeey@...glemail.com>
>
> This patch adds a firmware loader for the uPD720201K8-711-BAC-A
> and uPD720202K8-711-BAA-A variant. Both of these chips are listed
> in Renesas' R19UH0078EJ0500 Rev.5.00 "User's Manual: Hardware" as
> devices which need the firmware loader on page 2 in order to
> work as they "do not support the External ROM".
>
> The "Firmware Download Sequence" is describe in chapter
> "7.1 FW Download Interface" R19UH0078EJ0500 Rev.5.00 page 131.
>
> The firmware "K2013080.mem" is available from a USB3.0 Host to
> PCIe Adapter (PP2U-E card) "Firmware download" archive. An
> alternative version can be sourced from Netgear's WNDR4700 GPL
> archives.
>
> The release notes of the PP2U-E's "Firmware Download" ver 2.0.1.3
> (2012-06-15) state that the firmware is for the following devices:
> - uPD720201 ES 2.0 sample whose revision ID is 2.
> - uPD720201 ES 2.1 sample & CS sample & Mass product, ID is 3.
> - uPD720202 ES 2.0 sample & CS sample & Mass product, ID is 2.
>
> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
> Signed-off-by: Christian Lamparter <chunkeey@...glemail.com>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@...aro.org>
> [vkoul: fixed comments:
> used macros for timeout count and delay
> removed renesas_fw_alive_check
> cleaned renesas_fw_callback
> removed recurion for renesas_fw_download
> added MODULE_FIRMWARE
> removed length check]
> Tested-by: Christian Lamparter <chunkeey@...il.com>
> Signed-off-by: Vinod Koul <vkoul@...nel.org>
> ---
> drivers/usb/host/xhci-pci.c | 454 ++++++++++++++++++++++++++++++++++++
> 1 file changed, 454 insertions(+)
>
> diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> index c2fe218e051f..89ca46dd6825 100644
> --- a/drivers/usb/host/xhci-pci.c
> +++ b/drivers/usb/host/xhci-pci.c
> @@ -12,6 +12,8 @@
> #include <linux/slab.h>
> #include <linux/module.h>
> #include <linux/acpi.h>
> +#include <linux/firmware.h>
> +#include <linux/unaligned/access_ok.h>
>
> #include "xhci.h"
> #include "xhci-trace.h"
> @@ -55,6 +57,9 @@
> #define PCI_DEVICE_ID_AMD_PROMONTORYA_1 0x43bc
> #define PCI_DEVICE_ID_ASMEDIA_1042A_XHCI 0x1142
>
> +#define RENESAS_RETRY 1000
> +#define RENESAS_DELAY 10
So some devices are exhibiting failure on both ROM programming as well
as RAM load with messages:
ROM Download Step 34 failed at position 136 bytes
Firmware Download Step 2 failed at position 8 bytes with (-110)
So I am going to revert to older delay values! With those we dont get a
failures. yeah looks like ROM load takes a while on these
Thanks
--
~Vinod
Powered by blists - more mailing lists