[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <DM6PR02MB47796E3306C166A91E0BAE91AFE20@DM6PR02MB4779.namprd02.prod.outlook.com>
Date: Wed, 26 Jun 2019 11:22:33 +0000
From: Naga Sureshkumar Relli <nagasure@...inx.com>
To: Boris Brezillon <boris.brezillon@...labora.com>
CC: "miquel.raynal@...tlin.com" <miquel.raynal@...tlin.com>,
"helmut.grohne@...enta.de" <helmut.grohne@...enta.de>,
"richard@....at" <richard@....at>,
"dwmw2@...radead.org" <dwmw2@...radead.org>,
"computersforpeace@...il.com" <computersforpeace@...il.com>,
"marek.vasut@...il.com" <marek.vasut@...il.com>,
"vigneshr@...com" <vigneshr@...com>,
"bbrezillon@...nel.org" <bbrezillon@...nel.org>,
"yamada.masahiro@...ionext.com" <yamada.masahiro@...ionext.com>,
"linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [LINUX PATCH v17 1/2] mtd: rawnand: nand_micron: Do not over
write driver's read_page()/write_page()
Hi Boris,
> -----Original Message-----
> From: Boris Brezillon <boris.brezillon@...labora.com>
> Sent: Wednesday, June 26, 2019 12:18 PM
> To: Naga Sureshkumar Relli <nagasure@...inx.com>
> Cc: miquel.raynal@...tlin.com; helmut.grohne@...enta.de; richard@....at;
> dwmw2@...radead.org; computersforpeace@...il.com; marek.vasut@...il.com;
> vigneshr@...com; bbrezillon@...nel.org; yamada.masahiro@...ionext.com; linux-
> mtd@...ts.infradead.org; linux-kernel@...r.kernel.org
> Subject: Re: [LINUX PATCH v17 1/2] mtd: rawnand: nand_micron: Do not over write
> driver's read_page()/write_page()
>
> On Mon, 24 Jun 2019 22:46:29 -0600
> Naga Sureshkumar Relli <naga.sureshkumar.relli@...inx.com> wrote:
>
> > Add check before assigning chip->ecc.read_page() and
> > chip->ecc.write_page()
> >
> > Signed-off-by: Naga Sureshkumar Relli
> > <naga.sureshkumar.relli@...inx.com>
> > ---
> > drivers/mtd/nand/raw/nand_micron.c | 7 +++++--
> > 1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/mtd/nand/raw/nand_micron.c
> > b/drivers/mtd/nand/raw/nand_micron.c
> > index cbd4f09ac178..565f2696c747 100644
> > --- a/drivers/mtd/nand/raw/nand_micron.c
> > +++ b/drivers/mtd/nand/raw/nand_micron.c
> > @@ -500,8 +500,11 @@ static int micron_nand_init(struct nand_chip *chip)
> > chip->ecc.size = 512;
> > chip->ecc.strength = chip->base.eccreq.strength;
> > chip->ecc.algo = NAND_ECC_BCH;
> > - chip->ecc.read_page = micron_nand_read_page_on_die_ecc;
> > - chip->ecc.write_page = micron_nand_write_page_on_die_ecc;
> > + if (!chip->ecc.read_page)
> > + chip->ecc.read_page = micron_nand_read_page_on_die_ecc;
> > +
> > + if (!chip->ecc.write_page)
> > + chip->ecc.write_page = micron_nand_write_page_on_die_ecc;
>
> That's wrong, if you don't want on-die ECC to be used, simply don't set nand-ecc-mode to "on-
> die".
Ok. But if we want to use on-die ECC then you mean to say it is mandatory to use micron_nand_read/write_page_on_die_ecc()?
Regards,
Naga Sureshkumar Relli
>
> >
> > if (ondie == MICRON_ON_DIE_MANDATORY) {
> > chip->ecc.read_page_raw = nand_read_page_raw_notsupp;
Powered by blists - more mailing lists