lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 26 Jun 2019 14:27:04 +0200
From:   Christoph Hellwig <>
To:     Dan Williams <>,
        Jérôme Glisse <>,
        Jason Gunthorpe <>,
        Ben Skeggs <>
        John Hubbard <>
Subject: [PATCH 05/25] mm: don't clear ->mapping in hmm_devmem_free

->mapping isn't even used by HMM users, and the field at the same offset
in the zone_device part of the union is declared as pad.  (Which btw is
rather confusing, as DAX uses ->pgmap and ->mapping from two different
sides of the union, but DAX doesn't use hmm_devmem_free).

Signed-off-by: Christoph Hellwig <>
Reviewed-by: Jason Gunthorpe <>
Reviewed-by: John Hubbard <>
 mm/hmm.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/mm/hmm.c b/mm/hmm.c
index 376159a769fb..e7dd2ab8f9ab 100644
--- a/mm/hmm.c
+++ b/mm/hmm.c
@@ -1383,8 +1383,6 @@ static void hmm_devmem_free(struct page *page, void *data)
 	struct hmm_devmem *devmem = data;
-	page->mapping = NULL;
 	devmem->ops->free(devmem, page);

Powered by blists - more mailing lists