linux-kernel - Re: [PATCH v7 0/4] THP aware uprobe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0A9B714D-59D4-4F78-8625-831F76FB7797@fb.com>
Date:   Wed, 26 Jun 2019 00:03:12 +0000
From:   Song Liu <songliubraving@...com>
To:     LKML <linux-kernel@...r.kernel.org>, Linux-MM <linux-mm@...ck.org>,
        "Oleg Nesterov" <oleg@...hat.com>
CC:     Matthew Wilcox <matthew.wilcox@...cle.com>,
        "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Kernel Team <Kernel-team@...com>,
        William Kucharski <william.kucharski@...cle.com>
Subject: Re: [PATCH v7 0/4] THP aware uprobe

Hi Oleg, 

> On Jun 25, 2019, at 4:53 PM, Song Liu <songliubraving@...com> wrote:
> 
> This set makes uprobe aware of THPs.
> 
> Currently, when uprobe is attached to text on THP, the page is split by
> FOLL_SPLIT. As a result, uprobe eliminates the performance benefit of THP.
> 
> This set makes uprobe THP-aware. Instead of FOLL_SPLIT, we introduces
> FOLL_SPLIT_PMD, which only split PMD for uprobe.
> 
> TODO (temporarily removed in v7):
> After all uprobes within the THP are removed, regroup the PTE-mapped pages
> into huge PMD.
> 
> This set (plus a few THP patches) is also available at
> 
>   https://github.com/liu-song-6/linux/tree/uprobe-thp
> 

Do you have further comments/suggestions on this work? If not, could you 
please add your Acked-by or Reviewed-by? 

Thanks,
Song