lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 26 Jun 2019 09:56:22 +0800 From: Greg KH <gregkh@...uxfoundation.org> To: Simon Sandström <simon@...anor.nu> Cc: devel@...verdev.osuosl.org, gneukum1@...il.com, linux-kernel@...r.kernel.org Subject: Re: [PATCH 3/4] staging: kpc2000: remove unnecessary parentheses in kpc2000_spi.c On Tue, Jun 25, 2019 at 10:41:29AM +0200, Simon Sandström wrote: > Fixes checkpatch "CHECK: Unnecessary parentheses around '...'". > > Signed-off-by: Simon Sandström <simon@...anor.nu> > --- > drivers/staging/kpc2000/kpc2000_spi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/kpc2000/kpc2000_spi.c b/drivers/staging/kpc2000/kpc2000_spi.c > index 98484fbb9d2e..68b049f9ad69 100644 > --- a/drivers/staging/kpc2000/kpc2000_spi.c > +++ b/drivers/staging/kpc2000/kpc2000_spi.c > @@ -164,7 +164,7 @@ kp_spi_read_reg(struct kp_spi_controller_state *cs, int idx) > u64 val; > > addr += idx; > - if ((idx == KP_SPI_REG_CONFIG) && (cs->conf_cache >= 0)) { > + if (idx == KP_SPI_REG_CONFIG && cs->conf_cache >= 0) { Ick, no. I don't want to have to remember the priority order of operations. Leave this as-is, I HATE this checkpatch message. thanks, greg k-h
Powered by blists - more mailing lists