[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190626145636.GG28859@kadam>
Date: Wed, 26 Jun 2019 17:56:36 +0300
From: Dan Carpenter <dan.carpenter@...cle.com>
To: Tobias Nießen
<tobias.niessen@...d.uni-hannover.de>
Cc: gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
Sabrina Gaube <sabrina-gaube@....de>,
linux-kernel@...r.kernel.org, linux-kernel@...cs.fau.de
Subject: Re: [PATCH 1/2] staging: rts5208: Rewrite redundant if statement to
improve code style
Both these patches seem fine.
On Wed, Jun 26, 2019 at 04:28:56PM +0200, Tobias Nießen wrote:
> This commit uses the fact that
>
> if (a) {
> if (b) {
> ...
> }
> }
>
> can instead be written as
>
> if (a && b) {
> ...
> }
>
> without any change in behavior, allowing to decrease the indentation
> of the contained code block and thus reducing the average line length.
>
> Signed-off-by: Tobias Nießen <tobias.niessen@...d.uni-hannover.de>
> Signed-off-by: Sabrina Gaube <sabrina-gaube@....de>
Signed-off-by is like signing a legal document that you didn't put any
of SCO's secret UNIXWARE source code into your patch or do other illegal
activities. Everyone who handles a patch is supposed to Sign it.
It's weird to see Sabrina randomly signing your patches. Probably there
is a more appropriate kind of tag to use as well or instead such as
Co-Developed-by, Reviewed-by or Suggested-by.
regards,
dan carpenter
Powered by blists - more mailing lists