linux-kernel - Re: [PATCH] bonding: Always enable vlan tx offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <498bf1cb-1fb8-05a8-482a-79f37bf812dc@huawei.com>
Date:   Wed, 26 Jun 2019 23:29:30 +0800
From:   Yuehaibing <yuehaibing@...wei.com>
To:     Jiri Pirko <jiri@...nulli.us>
CC:     <davem@...emloft.net>, <sdf@...gle.com>, <jianbol@...lanox.com>,
        <jiri@...lanox.com>, <mirq-linux@...e.qmqm.pl>,
        <willemb@...gle.com>, <sdf@...ichev.me>, <j.vosburgh@...il.com>,
        <vfalico@...il.com>, <andy@...yhouse.net>,
        <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>
Subject: Re: [PATCH] bonding: Always enable vlan tx offload

On 2019/6/26 23:25, Jiri Pirko wrote:
> Wed, Jun 26, 2019 at 10:08:44AM CEST, yuehaibing@...wei.com wrote:
>> We build vlan on top of bonding interface, which vlan offload
>> is off, bond mode is 802.3ad (LACP) and xmit_hash_policy is
>> BOND_XMIT_POLICY_ENCAP34.
>>
>> Because vlan tx offload is off, vlan tci is cleared and skb push
>> the vlan header in validate_xmit_vlan() while sending from vlan
>> devices. Then in bond_xmit_hash, __skb_flow_dissect() fails to
>> get information from protocol headers encapsulated within vlan,
>> because 'nhoff' is points to IP header, so bond hashing is based
>> on layer 2 info, which fails to distribute packets across slaves.
>>
>> This patch always enable bonding's vlan tx offload, pass the vlan
>> packets to the slave devices with vlan tci, let them to handle
>> vlan implementation.
>>
>> Fixes: 278339a42a1b ("bonding: propogate vlan_features to bonding master")
>> Suggested-by: Jiri Pirko <jiri@...nulli.us>
>> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> 
> Acked-by: Jiri Pirko <jiri@...lanox.com>
> 
> Could you please do the same for team? Thanks!

Sure, will send it, thank you!

> 
> .
>