[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190627164530.GD9692@kroah.com>
Date: Fri, 28 Jun 2019 00:45:30 +0800
From: Greg KH <gregkh@...uxfoundation.org>
To: Christian Müller <muellerch-privat@....de>
Cc: devel@...verdev.osuosl.org,
Felix Trommer <felix.trommer@...mail.de>,
linux-kernel@...cs.fau.de, linux-kernel@...r.kernel.org,
johnfwhitmore@...il.com
Subject: Re: [PATCH v2 1/2] drivers/staging/rtl8192u: drop first comment line
On Thu, Jun 27, 2019 at 10:33:35AM +0200, Christian Müller wrote:
> As stated in coding-styles.rst multiline comments should be structured in a way,
> that the actual comment starts on the second line of the commented portion. E.g:
>
> /*
> * Multiline comments
> * should look like
> * this.
> */
>
> However, there is an exception to files in drivers/net/ and net/, where
> multiline comments are prefered to look like this:
>
> /* Mutliline comments for
> * drivers/net/ should look
> * like this.
> */
>
> The comments in this file initially looked like the first example.
> But since this file is part of a networking driver and thus should
> be moved to drivers/net/ one day, this patch adjusts the comments
> such that they are fitting to the style imposed for drivers/net/.
>
> Signed-off-by: Christian Müller <muellerch-privat@....de>
> Signed-off-by: Felix Trommer <felix.trommer@...mail.de>
> ---
> drivers/staging/rtl8192u/r8192U_dm.c | 69 ++++++++++------------------
> 1 file changed, 23 insertions(+), 46 deletions(-)
What changed from v1? That always goes below the --- line.
Please fix up and send v3.
thanks,
greg k-h
Powered by blists - more mailing lists