linux-kernel - Re: [PATCH v4 2/2] dt-bindings: mtd: Document Macronix raw NAND controller bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190627192609.0965f6d5@xps13>
Date:   Thu, 27 Jun 2019 19:26:09 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Mason Yang <masonccyang@...c.com.tw>
Cc:     marek.vasut@...il.com, linux-kernel@...r.kernel.org,
        linux-mtd@...ts.infradead.org, bbrezillon@...nel.org,
        dwmw2@...radead.org, computersforpeace@...il.com, vigneshr@...com,
        paul.burton@...s.com, liang.yang@...ogic.com, richard@....at,
        anders.roxell@...aro.org, christophe.kerello@...com,
        paul@...pouillou.net, jianxin.pan@...ogic.com, stefan@...er.ch,
        devicetree@...r.kernel.org, juliensu@...c.com.tw,
        lee.jones@...aro.org, broonie@...nel.org
Subject: Re: [PATCH v4 2/2] dt-bindings: mtd: Document Macronix raw NAND
 controller bindings

Hi Mason,

Mason Yang <masonccyang@...c.com.tw> wrote on Tue, 25 Jun 2019 14:10:56
+0800:

> Document the bindings used by the Macronix raw NAND controller.
> 
> Signed-off-by: Mason Yang <masonccyang@...c.com.tw>
> ---
>  .../devicetree/bindings/mtd/mxic-nand.txt          | 26 ++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mtd/mxic-nand.txt
> 
> diff --git a/Documentation/devicetree/bindings/mtd/mxic-nand.txt b/Documentation/devicetree/bindings/mtd/mxic-nand.txt
> new file mode 100644
> index 0000000..3d198e4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/mxic-nand.txt
> @@ -0,0 +1,26 @@
> +Macronix Raw NAND Controller Device Tree Bindings
> +-------------------------------------------------
> +
> +Required properties:
> +- compatible: should be "mxic,raw-nand-ctlr"

I would prefer "macronix,nand-controller"

> +- reg: should contain 1 entrie for the registers

                           entry

> +- reg-names: should contain "regs"

Not sure you need that?

> +- interrupts: interrupt line connected to this NAND controller
> +- clock-names: should contain "ps_clk", "send_clk" and "send_dly_clk"
> +- clocks: should contain 3 entries for the "ps_clk", "send_clk" and
> +	 "send_dly_clk" clocks

s/entries/phandles/ ?

> +
> +Example:
> +
> +	nand: mxic-nfc@...30000 {
> +		compatible = "mxic,raw-nand-ctlr";
> +		reg = <0x43c30000 0x10000>;
> +		reg-names = "regs";
> +		clocks = <&clkwizard 0>, <&clkwizard 1>, <&clkc 15>;
> +		clock-names = "send_clk", "send_dly_clk", "ps_clk";
> +
> +		nand-ecc-mode = "soft";
> +		nand-ecc-algo = "bch";
> +		nand-ecc-step-size = <512>;
> +		nand-ecc-strength = <8>;

The last 4 lines are probably not needed.

> +	};

Thanks,
Miquèl