linux-kernel - Re: [PATCH v5 05/26] leds: core: Add support for composing LED class device names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7b038be0-274d-54f7-46f4-3dbe346169b8@gmail.com>
Date:   Thu, 27 Jun 2019 20:28:06 +0200
From:   Jacek Anaszewski <jacek.anaszewski@...il.com>
To:     Oleh Kravchenko <oleg@....org.ua>, linux-leds@...r.kernel.org,
        pavel@....cz, dmurphy@...com
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        robh@...nel.org, dtor@...gle.com, linux@...ck-us.net,
        Baolin Wang <baolin.wang@...aro.org>,
        Daniel Mack <daniel@...que.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Simon Shields <simon@...eageos.org>
Subject: Re: [PATCH v5 05/26] leds: core: Add support for composing LED class
 device names

Hi Oleh,

On 6/26/19 10:07 PM, Oleh Kravchenko wrote:
> Hello Jacek,
> so after this patch will be merged.
> 
> There will be a way to define custom function name by DeviceTree?

Yes. We standardize LED functions just to avoid spreading many similarly
looking function names with the same semantics.

We don't enforce using new function definitions in any way.
It is possible to assign whatever you want to the DT label property
(however now deprecated) or to the new DT function property.

It will be however preferable to use standard LED_FUNCTION definitions
for new mainline bindings and dts files. Of course, as documentation
states, it will be possible to propose new ones if none of existing
fit for given application. This is only an initial set.

> 26.06.19 22:05, Jacek Anaszewski пише:
>> Gentle reminder.
>>
>> Pavel, Dan - any conclusions?
>>
>> This patch is the main part of the proposed changes,
>> so it would be good to spot any remaining issues.
>>
>> What needs a consensus is also a new
>> Documentation/leds/led-functions.txt file I introduce
>> in the patch 26/26.
>>
>> Best regards,
>> Jacek Anaszewski
> 

-- 
Best regards,
Jacek Anaszewski