linux-kernel - Re: [PATCH v4 0/2] Use NVMEM as reboot-mode write interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190627183330.aole6zumw3l2vyet@earth.universe>
Date:   Thu, 27 Jun 2019 20:33:30 +0200
From:   Sebastian Reichel <sre@...nel.org>
To:     Han Nandor <nandor.han@...sala.com>
Cc:     "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH v4 0/2] Use NVMEM as reboot-mode write interface

Hi,

On Wed, May 15, 2019 at 10:47:14AM +0000, Han Nandor wrote:
> Description
> -----------
> Extend the reboot mode driver to use a NVMEM cell as writing interface.
> 
> Testing
> -------
> The testing is done by configuring DT from a custom board.
> The NVMEM cell is configured in an RTC non-volatile memory.
> Kernel: 4.14.60 (the patchset was rebased on kernel master)
> 
> DT configurations:
> `
> ...
> reboot-mode-nvmem@0 {
>     compatible = "simple-mfd";
>     reboot-mode {
>         compatible = "nvmem-reboot-mode";
>         nvmem-cells = <&reboot_mode>;
>         nvmem-cell-names = "reboot-mode";
> 
>         mode-test       = <0x21969147>;
>     };
> };
> ...
> reboot_mode: nvmem_reboot_mode@0 {
>         reg = <0x00 0x4>;
> };
> ...
> `
> 
> 1. Reboot the system using the command `reboot test`
> 
> 2. Verify that kernel logs show that reboot was done in mode `test`:
> PASS
> `[  413.957172] reboot: Restarting system with command 'test' `
> 
> 3. Stop in U-Boot and verify that mode `test` magic value is present
> in RTCs non-volatile memory: PASS
> 
> Kernel: 5.1.0-rc3
> 
> 1. Configure `arch/arm/configs/imx_v6_v7_defconfig` to contain 
> `CONFIG_NVMEM_REBOOT_MODE=y`
> 2. Verify that Kernel compiles successful: PASS
> `
> make ARCH=arm CROSS_COMPILE=arm-linux-gnu- imx_v6_v7_defconfig zImage
> ...
> CC      drivers/power/reset/nvmem-reboot-mode.o
> ...
> Kernel: arch/arm/boot/zImage is ready
> `
> Changes since v1:
> -----------------
>  - split the documentation on a separate patch
>  - add a missing header
> 
> Changes since v2:
> ----------------
>  - change the module license to GPL since GPL v2 is deprecated
> 
> Changes since v3:
> ----------------
>  - documentation updated according to the comments

Thanks, queued. Please fix your git/mail setup, I had to fix the
line endings (\r\n -> \n) to apply this.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)