linux-kernel - Re: [PATCH 10/87] block: skd_main.c: Remove call to memset after dma_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 27 Jun 2019 19:37:23 +0000
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@....com>
To:     Fuqian Huang <huangfq.daxian@...il.com>
CC:     Damien Le Moal <Damien.LeMoal@....com>,
        Jens Axboe <axboe@...nel.dk>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 10/87] block: skd_main.c: Remove call to memset after
 dma_alloc_coherent

Looks good.

Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@....com>

On 06/27/2019 10:35 AM, Fuqian Huang wrote:
> In commit af7ddd8a627c
> ("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"),
> dma_alloc_coherent has already zeroed the memory.
> So memset is not needed.
>
> Signed-off-by: Fuqian Huang <huangfq.daxian@...il.com>
> ---
>   drivers/block/skd_main.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c
> index c479235862e5..51569c199a6c 100644
> --- a/drivers/block/skd_main.c
> +++ b/drivers/block/skd_main.c
> @@ -2694,7 +2694,6 @@ static int skd_cons_skmsg(struct skd_device *skdev)
>   		     (FIT_QCMD_ALIGN - 1),
>   		     "not aligned: msg_buf %p mb_dma_address %pad\n",
>   		     skmsg->msg_buf, &skmsg->mb_dma_address);
> -		memset(skmsg->msg_buf, 0, SKD_N_FITMSG_BYTES);
>   	}
>
>   err_out:
>