linux-kernel - Re: [PATCH v7 1/7] Documentation: DT: arm: add support for sockets defining package boundaries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <513883349e80792884b3754c259357d8066ad348.camel@wdc.com>
Date:   Thu, 27 Jun 2019 19:58:50 +0000
From:   Atish Patra <Atish.Patra@....com>
To:     "paul.walmsley@...ive.com" <paul.walmsley@...ive.com>,
        "sudeep.holla@....com" <sudeep.holla@....com>
CC:     "will.deacon@....com" <will.deacon@....com>,
        "robh@...nel.org" <robh@...nel.org>,
        "rfontana@...hat.com" <rfontana@...hat.com>,
        "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "palmer@...ive.com" <palmer@...ive.com>,
        "mchehab+samsung@...nel.org" <mchehab+samsung@...nel.org>,
        "aou@...s.berkeley.edu" <aou@...s.berkeley.edu>,
        "Jonathan.Cameron@...wei.com" <Jonathan.Cameron@...wei.com>,
        "catalin.marinas@....com" <catalin.marinas@....com>,
        "mingo@...nel.org" <mingo@...nel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "ottosabart@...erm.com" <ottosabart@...erm.com>,
        "morten.rasmussen@....com" <morten.rasmussen@....com>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "rafael@...nel.org" <rafael@...nel.org>,
        "anup@...infault.org" <anup@...infault.org>,
        "linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>
Subject: Re: [PATCH v7 1/7] Documentation: DT: arm: add support for sockets
 defining package boundaries

On Wed, 2019-06-26 at 19:18 -0700, Atish Patra wrote:
> On 6/26/19 5:31 PM, Paul Walmsley wrote:
> > Hi Sudeep, Atish,
> > 
> > On Mon, 17 Jun 2019, Atish Patra wrote:
> > 
> > > From: Sudeep Holla <sudeep.holla@....com>
> > > 
> > > The current ARM DT topology description provides the operating
> > > system
> > > with a topological view of the system that is based on leaf nodes
> > > representing either cores or threads (in an SMT system) and a
> > > hierarchical set of cluster nodes that creates a hierarchical
> > > topology
> > > view of how those cores and threads are grouped.
> > > 
> > > However this hierarchical representation of clusters does not
> > > allow to
> > > describe what topology level actually represents the physical
> > > package or
> > > the socket boundary, which is a key piece of information to be
> > > used by
> > > an operating system to optimize resource allocation and
> > > scheduling.
> > > 
> > > Lets add a new "socket" node type in the cpu-map node to describe
> > > the
> > > same.
> > > 
> > > Signed-off-by: Sudeep Holla <sudeep.holla@....com>
> > > Reviewed-by: Rob Herring <robh@...nel.org>
> > 
> > This one doesn't apply cleanly here on top of v5.2-rc2, Linus's
> > master
> > branch, and next-20190626.  The reject file is below.  Am I missing
> > a patch?
> > 
> 
> That's weird. I could apply the patch from any git tree (github or 
> git.kernel.org) but not from mail or patchworks.
> 
> git log doesn't show any recent modifications of that file. I am
> trying 
> to figure out what's wrong.

The space changes in this patch caused the conflict. The patch was
generated with -b which was suggested during the initial review. 

I should removed it before sending v7. My bad.
I have fixed that and sent a v8 that should be cleanly applied on
latest master. The patch series is also available at 

https://github.com/atishp04/linux/tree/5.2-rc6_topology

Regards,
Atish
> > - Paul
> > 
> > --- Documentation/devicetree/bindings/arm/topology.txt
> > +++ Documentation/devicetree/bindings/arm/topology.txt
> > @@ -185,13 +206,15 @@ Bindings for cluster/cpu/thread nodes are
> > defined as follows:
> >   4 - Example dts
> >   ===========================================
> >   
> > -Example 1 (ARM 64-bit, 16-cpu system, two clusters of clusters):
> > +Example 1 (ARM 64-bit, 16-cpu system, two clusters of clusters in
> > a single
> > +physical socket):
> >   
> >   cpus {
> >   	#size-cells = <0>;
> >   	#address-cells = <2>;
> >   
> >   	cpu-map {
> > +		socket0 {
> >   			cluster0 {
> >   				cluster0 {
> >   					core0 {
> > 
> 
>