linux-kernel - Re: [PATCH 80/87] net: hippi: remove memset after pci_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <518f3f6a-9d1b-11f8-e900-fcdc9e140110@gmail.com>
Date:   Thu, 27 Jun 2019 16:06:32 -0400
From:   Jes Sorensen <jes.sorensen@...il.com>
To:     Fuqian Huang <huangfq.daxian@...il.com>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 80/87] net: hippi: remove memset after
 pci_alloc_consistent

On 6/27/19 1:44 PM, Fuqian Huang wrote:
> pci_alloc_consistent calls dma_alloc_coherent directly.
> In commit af7ddd8a627c
> ("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"),
> dma_alloc_coherent has already zeroed the memory.
> So memset is not needed.
> 
> Signed-off-by: Fuqian Huang <huangfq.daxian@...il.com>
> ---
>  drivers/net/hippi/rrunner.c | 2 --
>  1 file changed, 2 deletions(-)

Acked-by: Jes Sorensen <Jes.Sorensen@...il.com>

> diff --git a/drivers/net/hippi/rrunner.c b/drivers/net/hippi/rrunner.c
> index 7b9350dbebdd..2a6ec5394966 100644
> --- a/drivers/net/hippi/rrunner.c
> +++ b/drivers/net/hippi/rrunner.c
> @@ -1196,7 +1196,6 @@ static int rr_open(struct net_device *dev)
>  		goto error;
>  	}
>  	rrpriv->rx_ctrl_dma = dma_addr;
> -	memset(rrpriv->rx_ctrl, 0, 256*sizeof(struct ring_ctrl));
>  
>  	rrpriv->info = pci_alloc_consistent(pdev, sizeof(struct rr_info),
>  					    &dma_addr);
> @@ -1205,7 +1204,6 @@ static int rr_open(struct net_device *dev)
>  		goto error;
>  	}
>  	rrpriv->info_dma = dma_addr;
> -	memset(rrpriv->info, 0, sizeof(struct rr_info));
>  	wmb();
>  
>  	spin_lock_irqsave(&rrpriv->lock, flags);
>