linux-kernel - Re: [PATCH] cpufreq: pcc-cpufreq: Fail initialization if driver cannot be registered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5175938.k7Tzu7MeQO@kreacher>
Date:   Fri, 28 Jun 2019 00:00:37 +0200
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Viresh Kumar <viresh.kumar@...aro.org>,
        David Arcari <darcari@...hat.com>
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cpufreq: pcc-cpufreq: Fail initialization if driver cannot be registered

On Friday, June 7, 2019 5:05:46 AM CEST Viresh Kumar wrote:
> On 06-06-19, 14:50, David Arcari wrote:
> > Make pcc_cpufreq_init() return error codes when the driver cannot be
> > registered.  Otherwise the driver can shows up loaded via lsmod even
> > though it failed initialization.  This is confusing to the user.
> > 
> > Signed-off-by: David Arcari <darcari@...hat.com>
> > Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>
> > Cc: Viresh Kumar <viresh.kumar@...aro.org>
> > ---
> >  drivers/cpufreq/pcc-cpufreq.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/cpufreq/pcc-cpufreq.c b/drivers/cpufreq/pcc-cpufreq.c
> > index 1e5e64643c3a..fdc767fdbe6a 100644
> > --- a/drivers/cpufreq/pcc-cpufreq.c
> > +++ b/drivers/cpufreq/pcc-cpufreq.c
> > @@ -582,10 +582,10 @@ static int __init pcc_cpufreq_init(void)
> >  
> >  	/* Skip initialization if another cpufreq driver is there. */
> >  	if (cpufreq_get_current_driver())
> > -		return 0;
> > +		return -EEXIST;
> >  
> >  	if (acpi_disabled)
> > -		return 0;
> > +		return -ENODEV;
> >  
> >  	ret = pcc_cpufreq_probe();
> >  	if (ret) {
> 
> Acked-by: Viresh Kumar <viresh.kumar@...aro.org>

Applied, thanks!