linux-kernel - Re: linux-next: Fixes tag needs some work in the bpf tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <134f90ff-13f8-b7c1-9693-2f2649245c38@iogearbox.net>
Date:   Fri, 28 Jun 2019 00:25:54 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc:     Roman Gushchin <guro@...com>, Alexei Starovoitov <ast@...nel.org>,
        Networking <netdev@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the bpf tree

On 06/27/2019 03:45 AM, Stephen Rothwell wrote:
> Hi all,
> 
> On Wed, 26 Jun 2019 16:36:50 -0700 Alexei Starovoitov <alexei.starovoitov@...il.com> wrote:
>>
>> On Wed, Jun 26, 2019 at 3:14 PM Roman Gushchin <guro@...com> wrote:
>>>
>>> On Thu, Jun 27, 2019 at 08:05:21AM +1000, Stephen Rothwell wrote:  
>>>>
>>>> In commit
>>>>
>>>>   12771345a467 ("bpf: fix cgroup bpf release synchronization")
>>>>
>>>> Fixes tag
>>>>
>>>>   Fixes: 4bfc0bb2c60e ("bpf: decouple the lifetime of cgroup_bpf from
>>>>
>>>> has these problem(s):
>>>>
>>>>   - Subject has leading but no trailing parentheses
>>>>   - Subject has leading but no trailing quotes
>>>>
>>>> Please don't split Fixes tags across more than one line.  
>>>
>>> Oops, sorry.
>>>
>>> Alexei, can you fix this in place?
>>> Or should I send an updated version?  
>>
>> I cannot easily do it since -p and --signoff are incompatible flags.
>> I need to use -p to preserve merge commits,
>> but I also need to use --signoff to add my sob to all
>> other commits that were committed by Daniel
>> after your commit.
>>
>> Daniel, can you fix Roman's patch instead?
>> you can do:
>> git rebase -i -p  12771345a467^
>> fix Roman's, add you sob only to that one
>> and re-push the whole thing.

(Fixed in bpf-next.)