linux-kernel - Re: [PATCH AUTOSEL 5.1 07/51] ASoC: soc-dpm: fixup DAI active unbalance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190627002059.GN7898@sasha-vm>
Date:   Wed, 26 Jun 2019 20:20:59 -0400
From:   Sasha Levin <sashal@...nel.org>
To:     Mark Brown <broonie@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        Vinod Koul <vkoul@...nel.org>
Subject: Re: [PATCH AUTOSEL 5.1 07/51] ASoC: soc-dpm: fixup DAI active
 unbalance

On Wed, Jun 26, 2019 at 11:03:15AM +0100, Mark Brown wrote:
>On Tue, Jun 25, 2019 at 11:40:23PM -0400, Sasha Levin wrote:
>> From: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
>>
>> [ Upstream commit f7c4842abfa1a219554a3ffd8c317e8fdd979bec ]
>>
>> snd_soc_dai_link_event() is updating snd_soc_dai :: active,
>> but it is unbalance.
>> It counts up if it has startup callback.
>
>Are you *sure* this doesn't have dependencies?

The actual code seems to correspond with the issue described in the
commit message, so I'd think not.

I can remove this patch if you're not confident about it.

--
Thanks,
Sasha