linux-kernel - Re: [PATCH v5 1/4] ACPI/PPTT: Modify node flag detection to find last IDENTICAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c36d197b-9f85-4681-69b6-a573451b5ed6@huawei.com>
Date:   Thu, 27 Jun 2019 10:10:42 +0800
From:   Hanjun Guo <guohanjun@...wei.com>
To:     Jeremy Linton <jeremy.linton@....com>,
        <linux-arm-kernel@...ts.infradead.org>
CC:     <linux-acpi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <catalin.marinas@....com>, <will.deacon@....com>,
        <rjw@...ysocki.net>, <lenb@...nel.org>, <mark.rutland@....com>,
        <lorenzo.pieralisi@....com>, <sudeep.holla@....com>,
        Hanjun Gou <gouhanjun@...wei.com>
Subject: Re: [PATCH v5 1/4] ACPI/PPTT: Modify node flag detection to find last
 IDENTICAL

On 2019/6/27 5:37, Jeremy Linton wrote:
> The ACPI specification implies that the IDENTICAL flag should be
> set on all non leaf nodes where the children are identical.
> This means that we need to be searching for the last node with
> the identical flag set rather than the first one.
> 
> Since this flag is also dependent on the table revision, we
> need to add a bit of extra code to verify the table revision,
> and the next node's state in the traversal. Since we want to
> avoid function pointers here, lets just special case
> the IDENTICAL flag.
> 
> Tested-by: Hanjun Gou <gouhanjun@...wei.com>

This is wrong, my family name is Guo, and please correct my
email address as well (for all the 4 patches).

Thanks
Hanjun