linux-kernel - Re: [PATCH RESEND] mfd: hi655x-pmic: Fix missing return value check for devm_regmap_init_mmio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 27 Jun 2019 10:57:24 +0800
From:   Axel Lin <axel.lin@...ics.com>
To:     Chen Feng <puck.chen@...ilicon.com>
Cc:     Lee Jones <lee.jones@...aro.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RESEND] mfd: hi655x-pmic: Fix missing return value check
 for devm_regmap_init_mmio_clk

Hi Chen,

Chen Feng <puck.chen@...ilicon.com> 於 2019年6月27日 週四 上午10:03寫道：
>
> Thanks
I assume this is an Ack.
If you can add your Acked-by in the reply, it's easier for maintainer to accept
the patch.

>
> On 2019/6/26 21:30, Axel Lin wrote:
> > Since devm_regmap_init_mmio_clk can fail, add return value checking.
> >
> > Signed-off-by: Axel Lin <axel.lin@...ics.com>
> > Acked-by: Chen Feng <puck.chen@...ilicon.com>
> > ---
> > This was sent on https://lkml.org/lkml/2019/3/6/904
> >
> >   drivers/mfd/hi655x-pmic.c | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/mfd/hi655x-pmic.c b/drivers/mfd/hi655x-pmic.c
> > index 96c07fa1802a..6693f74aa6ab 100644
> > --- a/drivers/mfd/hi655x-pmic.c
> > +++ b/drivers/mfd/hi655x-pmic.c
> > @@ -112,6 +112,8 @@ static int hi655x_pmic_probe(struct platform_device *pdev)
> >
> >       pmic->regmap = devm_regmap_init_mmio_clk(dev, NULL, base,
> >                                                &hi655x_regmap_config);
> > +     if (IS_ERR(pmic->regmap))
> > +             return PTR_ERR(pmic->regmap);
> >
> >       regmap_read(pmic->regmap, HI655X_BUS_ADDR(HI655X_VER_REG), &pmic->ver);
> >       if ((pmic->ver < PMU_VER_START) || (pmic->ver > PMU_VER_END)) {
> >
>