linux-kernel - Re: linux-next: build warning after merge of the mfd tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1b5aa183-6e33-ee15-4c65-5b4cdf7655af@ti.com>
Date:   Thu, 27 Jun 2019 11:29:18 +0530
From:   Keerthy <j-keerthy@...com>
To:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Lee Jones <lee.jones@...aro.org>
CC:     Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        <gustavo@...eddedor.com>, <keescook@...omium.org>
Subject: Re: linux-next: build warning after merge of the mfd tree



On 27/06/19 10:41 AM, Stephen Rothwell wrote:
> Hi Lee,
> 
> After merging the mfd tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
> 
> drivers/regulator/lp87565-regulator.c: In function 'lp87565_regulator_probe':
> drivers/regulator/lp87565-regulator.c:182:11: warning: this statement may fall through [-Wimplicit-fallthrough=]
>     max_idx = LP87565_BUCK_3210;

Missed adding a break here. Can i send a patch on top of linux-next?

>     ~~~~~~~~^~~~~~~~~~~~~~~~~~~
> drivers/regulator/lp87565-regulator.c:183:2: note: here
>    default:
>    ^~~~~~~
> 
> Introduced by commit
> 
>    7ee63bd74750 ("regulator: lp87565: Add 4-phase lp87561 regulator support")
> 
> I get these warnings because I am building with -Wimplicit-fallthrough
> in attempt to catch new additions early.  The gcc warning can be turned
> off by adding a /* fall through */ comment at the point the fall through
> happens (assuming that the fall through is intentional).
>