linux-kernel - Re: [PATCH v2] jffs2: remove C++ style comments from uapi header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <957967732.18164.1561621143523.JavaMail.zimbra@nod.at>
Date:   Thu, 27 Jun 2019 09:39:03 +0200 (CEST)
From:   Richard Weinberger <richard@....at>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     Vignesh Raghavendra <vigneshr@...com>,
        Boris Brezillon <bbrezillon@...nel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Marek Vasut <marek.vasut@...il.com>,
        linux-mtd <linux-mtd@...ts.infradead.org>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Brian Norris <computersforpeace@...il.com>,
        David Woodhouse <dwmw2@...radead.org>
Subject: Re: [PATCH v2] jffs2: remove C++ style comments from uapi header

----- Ursprüngliche Mail -----
> Von: "Masahiro Yamada" <yamada.masahiro@...ionext.com>
> An: "richard" <richard@....at>
> CC: "Vignesh Raghavendra" <vigneshr@...com>, "Boris Brezillon" <bbrezillon@...nel.org>, "linux-kernel"
> <linux-kernel@...r.kernel.org>, "Marek Vasut" <marek.vasut@...il.com>, "linux-mtd" <linux-mtd@...ts.infradead.org>,
> "Miquel Raynal" <miquel.raynal@...tlin.com>, "Brian Norris" <computersforpeace@...il.com>, "David Woodhouse"
> <dwmw2@...radead.org>
> Gesendet: Donnerstag, 27. Juni 2019 09:06:31
> Betreff: Re: [PATCH v2] jffs2: remove C++ style comments from uapi header

> On Tue, Jun 18, 2019 at 3:20 PM Richard Weinberger <richard@....at> wrote:
>>
>> ----- Ursprüngliche Mail -----
>> > Von: "Masahiro Yamada" <yamada.masahiro@...ionext.com>
>> > An: "linux-mtd" <linux-mtd@...ts.infradead.org>
>> > CC: "Boris Brezillon" <bbrezillon@...nel.org>, "Miquel Raynal"
>> > <miquel.raynal@...tlin.com>, "Brian Norris"
>> > <computersforpeace@...il.com>, "Vignesh Raghavendra" <vigneshr@...com>, "Marek
>> > Vasut" <marek.vasut@...il.com>,
>> > "Masahiro Yamada" <yamada.masahiro@...ionext.com>, "richard" <richard@....at>,
>> > "David Woodhouse" <dwmw2@...radead.org>,
>> > "linux-kernel" <linux-kernel@...r.kernel.org>
>> > Gesendet: Dienstag, 18. Juni 2019 05:09:26
>> > Betreff: [PATCH v2] jffs2: remove C++ style comments from uapi header
>>
>> > Linux kernel tolerates C++ style comments these days. Actually, the
>> > SPDX License tags for .c files start with //.
>> >
>> > On the other hand, uapi headers are written in more strict C, where
>> > the C++ comment style is forbidden.
>> >
>> > I simply dropped these lines instead of fixing the comment style.
>> >
>> > This code has been always commented out since it was added around
>> > Linux 2.4.9 (i.e. commented out for more than 17 years).
>> >
>> > 'Maybe later...' will never happen.
>>
>> :-)
>>
>> > Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
>>
>> Acked-by: Richard Weinberger <richard@....at>
>>
>> Thanks,
>> //richard
> 
> 
> Will this be picked up for v5.3-rc1 ?

Yes.

Thanks,
//richard