[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <BN8PR12MB32669F715CFC897D72F193AFD3FD0@BN8PR12MB3266.namprd12.prod.outlook.com>
Date: Thu, 27 Jun 2019 07:54:45 +0000
From: Jose Abreu <Jose.Abreu@...opsys.com>
To: Andrew Lunn <andrew@...n.ch>, Jose Abreu <Jose.Abreu@...opsys.com>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
Joao Pinto <Joao.Pinto@...opsys.com>,
"David S . Miller" <davem@...emloft.net>,
Giuseppe Cavallaro <peppe.cavallaro@...com>,
Alexandre Torgue <alexandre.torgue@...com>
Subject: RE: [PATCH net-next 07/10] net: stmmac: Enable support for > 32 Bits
addressing in XGMAC
From: Andrew Lunn <andrew@...n.ch>
> > +
> > + if (priv->dma_cap.addr64) {
> > + ret = dma_set_mask_and_coherent(device,
> > + DMA_BIT_MASK(priv->dma_cap.addr64));
> > + if (!ret)
> > + dev_info(priv->device, "Using %d bits DMA width\n",
> > + priv->dma_cap.addr64);
> > + }
>
> Hi Jose
>
> If dma_set_mask_and_coherent() fails, i think you are supposed to fall
> back to 32 bits. So you might want to clear priv->dma_cap.addr64.
Yeah, seems right. Thanks for pointing!
Powered by blists - more mailing lists