linux-kernel - Re: [PATCH] usb: musb: sunxi: propagate devicetree node to glue pdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yw1x1rzfic7e.fsf@mansr.com>
Date:   Thu, 27 Jun 2019 10:56:05 +0100
From:   Måns Rullgård <mans@...sr.com>
To:     Bin Liu <b-liu@...com>, Maxime Ripard <maxime.ripard@...tlin.com>,
        Chen-Yu Tsai <wens@...e.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: musb: sunxi: propagate devicetree node to glue pdev

Mans Rullgard <mans@...sr.com> writes:

> In order for devicetree nodes to be correctly associated with attached
> devices, the controller node needs to be propagated to the glue device.
>
> Signed-off-by: Mans Rullgard <mans@...sr.com>
> ---
> This depends on 2c1ea6abde88 ("platform: set of_node in
> platform_device_register_full()") which is currently winding its way
> through the staging trees.

That patch is in v5.1, so this one can go ahead now.  Assuming there are
no objections, of course.

> ---
>  drivers/usb/musb/sunxi.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/musb/sunxi.c b/drivers/usb/musb/sunxi.c
> index 832a41f9ee7d..a72665fbf111 100644
> --- a/drivers/usb/musb/sunxi.c
> +++ b/drivers/usb/musb/sunxi.c
> @@ -781,6 +781,8 @@ static int sunxi_musb_probe(struct platform_device *pdev)
>  	pinfo.name	 = "musb-hdrc";
>  	pinfo.id	= PLATFORM_DEVID_AUTO;
>  	pinfo.parent	= &pdev->dev;
> +	pinfo.fwnode	= of_fwnode_handle(pdev->dev.of_node);
> +	pinfo.of_node_reused = true;
>  	pinfo.res	= pdev->resource;
>  	pinfo.num_res	= pdev->num_resources;
>  	pinfo.data	= &pdata;
> -- 
> 2.20.1
>

-- 
Måns Rullgård