linux-kernel - Re: [PATCH v3 00/12] Introduce generic ONFI support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190627164914.1cae84ff@xps13>
Date:   Thu, 27 Jun 2019 16:49:14 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     "Shivamurthy Shastri (sshivamurthy)" <sshivamurthy@...ron.com>
Cc:     Richard Weinberger <richard@....at>,
        David Woodhouse <dwmw2@...radead.org>,
        Brian Norris <computersforpeace@...il.com>,
        Marek Vasut <marek.vasut@...il.com>,
        Vignesh Raghavendra <vigneshr@...com>,
        Boris Brezillon <bbrezillon@...nel.org>,
        Yixun Lan <yixun.lan@...ogic.com>,
        Lucas Stach <dev@...xeye.de>,
        Anders Roxell <anders.roxell@...aro.org>,
        Stefan Agner <stefan@...er.ch>,
        Marcel Ziswiler <marcel.ziswiler@...adex.com>,
        "Bean Huo (beanhuo)" <beanhuo@...ron.com>,
        Paul Cercueil <paul@...pouillou.net>,
        Frieder Schrempf <frieder.schrempf@...tron.de>,
        Chuanhong Guo <gch981213@...il.com>,
        "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 00/12] Introduce generic ONFI support

Hi Shivamurthy,

"Shivamurthy Shastri (sshivamurthy)" <sshivamurthy@...ron.com> wrote on
Mon, 3 Jun 2019 12:43:20 +0000:

> Current support to ONFI parameter page is only for raw NAND, this patch
> series turn ONFI support into generic. So that, other NAND devices like
> SPI NAND can use this.
> 
> There are five parts in this series.
> 1. Prepare for turning ONFI into generic
> 2. Turn ONFI into generic, which can be used by SPI NANDs later
> 3. Turn SPI NAND core to use parameter page
> 4. Redesign Micron SPI NAND driver implementation
> 5. Support for new Micron SPI NAND devices
> 

I am very sorry for the delay, I will have a deep look at your series
very soon.

> Changes in V3
> -------------
> 
> * Rebased to nand/next
> * Split the patches as per suggestion
> * Addressed the comments
> * Some fixes which I missed in last version

As a simple note, please mind that "addressed the comments" is way too
generic. "Some fixes" as well. I have plenty of series to follow, you
need to do very careful when you write this changelog, it is important
for me.

Also, for the next series you submit, please use a threaded logic where
all patches are answers to the cover letter (this way it appears as a
thread and it is considered as one series by patchwork.

Thanks,
Miquèl