linux-kernel - Re: linux-next: Tree for Jun 26 (security/integrity/ima/)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <596322b1-1c89-0538-5c26-cd132b03e3eb@infradead.org>
Date:   Thu, 27 Jun 2019 08:08:17 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     David Howells <dhowells@...hat.com>,
        Mimi Zohar <zohar@...ux.ibm.com>
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-integrity@...r.kernel.org,
        Dmitry Kasatkin <dmitry.kasatkin@...il.com>,
        linux-security-module <linux-security-module@...r.kernel.org>
Subject: Re: linux-next: Tree for Jun 26 (security/integrity/ima/)

On 6/27/19 6:29 AM, David Howells wrote:
> Mimi Zohar <zohar@...ux.ibm.com> wrote:
> 
>>>   CC      security/integrity/ima/ima_fs.o
>>> In file included from ../security/integrity/ima/ima.h:25:0,
>>>                  from ../security/integrity/ima/ima_fs.c:26:
>>> ../security/integrity/ima/../integrity.h:170:18: warning: ‘struct key_acl’ declared inside parameter list [enabled by default]
>>>            struct key_acl *acl)
>>>                   ^
>>> ../security/integrity/ima/../integrity.h:170:18: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
>>
>> David, CONFIG_INTEGRITY_SIGNATURE is dependent on KEYS being enabled,
>> but the stub functions are not.  There's now a dependency on
>> key_acl().
> 
> I added a forward declaration for struct key_acl into
> security/integrity/integrity.h as you can see here:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/diff/security/integrity/integrity.h?h=keys-acl&id=75ce113a1d56880e5abd37fa664ea9af399d2bcd
> 
> which might not have made it into linux-next before you used it.

No problem in linux-next 20190627.

Thanks.

-- 
~Randy