linux-kernel - Re: [PATCH] riscv: ccache: Remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.9999.1906270911270.12689@viisi.sifive.com>
Date:   Thu, 27 Jun 2019 09:13:55 -0700 (PDT)
From:   Paul Walmsley <paul.walmsley@...ive.com>
To:     Yash Shah <yash.shah@...ive.com>
cc:     linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org,
        palmer@...ive.com, aou@...s.berkeley.edu, sachin.ghadi@...ive.com
Subject: Re: [PATCH] riscv: ccache: Remove unused variable

On Thu, 27 Jun 2019, Yash Shah wrote:

> Reading the count register clears the interrupt signal. Currently, the
> count registers are read into 'regval' variable but the variable is
> never used. Therefore remove it.
> 
> Signed-off-by: Yash Shah <yash.shah@...ive.com>

This is a good start.  Could you also add comments in the code that 
describe what those reads are doing, as you did in the patch description?  
Otherwise they look pretty mysterious.


- Paul