linux-kernel - Re: [PATCH] mtd: rawnand: ingenic: fix ingenic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190627184047.6faa058a@xps13>
Date:   Thu, 27 Jun 2019 18:40:47 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Arnd Bergmann <arnd@...db.de>, Paul Cercueil <paul@...pouillou.net>
Cc:     David Woodhouse <dwmw2@...radead.org>,
        Brian Norris <computersforpeace@...il.com>,
        Marek Vasut <marek.vasut@...il.com>,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        linux-mtd <linux-mtd@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mtd: rawnand: ingenic: fix ingenic_ecc dependency

Hi Paul,

Miquel Raynal <miquel.raynal@...tlin.com> wrote on Mon, 17 Jun 2019
14:16:59 +0200:

> Hello,
> 
> Arnd Bergmann <arnd@...db.de> wrote on Mon, 17 Jun 2019 14:12:48 +0200:
> 
> > On Mon, Jun 17, 2019 at 1:24 PM Paul Cercueil <paul@...pouillou.net> wrote:
> >   
> > > I think there's a better way to fix it, only in Kconfig.
> > >
> > > * Add a bool symbol MTD_NAND_INGENIC_USE_HW_ECC
> > > * Have the three ECC/BCH drivers select this symbol instead of
> > >   MTD_NAND_INGENIC_ECC
> > > * Add the following to the MTD_NAND_JZ4780 config option:
> > >   "select MTD_NAND_INGENIC_ECC if MTD_NAND_INGENIC_USE_HW_ECC"    
> > 
> > I don't see much difference to my approach here, but if you want
> > to submit that version with 'Reported-by: Arnd Bergmann <arnd@...db.de>',
> > please do so.
> > 
> > Yet another option would be to use Makefile code to link both
> > files into one module, and remove the EXPORT_SYMBOL statements:
> > 
> > obj-$(CONFIG_MTD_NAND_JZ4780) += jz4780_nand.o
> > jz4780_nand-y += ingenic_nand.o
> > jz4780_nand-$(CONFIG_MTD_NAND_INGENIC_ECC) += ingenic_ecc.o
> >   
> 
> I personally have a preference for this one.

Would you mind sending the above change? I forgot about it but I would
like to queue it for the next release. Preferably the last version Arnd
proposed.


Thanks,
Miquèl