lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 28 Jun 2019 12:13:43 -0400 From: Neil Horman <nhorman@...driver.com> To: Fuqian Huang <huangfq.daxian@...il.com> Cc: Seth Heasley <seth.heasley@...el.com>, Wolfram Sang <wsa@...-dreams.de>, Jarkko Nikula <jarkko.nikula@...ux.intel.com>, linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 19/87] i2c: busses: Remove call to memset after dmam_alloc_coherent On Fri, Jun 28, 2019 at 01:36:51AM +0800, Fuqian Huang wrote: > In commit af7ddd8a627c > ("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"), > dmam_alloc_coherent has already zeroed the memory. > So memset is not needed. > > Signed-off-by: Fuqian Huang <huangfq.daxian@...il.com> > --- > drivers/i2c/busses/i2c-ismt.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-ismt.c b/drivers/i2c/busses/i2c-ismt.c > index 02d23edb2fb1..2f95e25a10f7 100644 > --- a/drivers/i2c/busses/i2c-ismt.c > +++ b/drivers/i2c/busses/i2c-ismt.c > @@ -781,8 +781,6 @@ static int ismt_dev_init(struct ismt_priv *priv) > if (!priv->hw) > return -ENOMEM; > > - memset(priv->hw, 0, (ISMT_DESC_ENTRIES * sizeof(struct ismt_desc))); > - > priv->head = 0; > init_completion(&priv->cmp); > > -- > 2.11.0 > > Acked-by: Neil Horman <nhorman@...driver.com>
Powered by blists - more mailing lists