linux-kernel - Re: [PATCH] [v2] crypto: serpent - mark __serpent_setkey

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 28 Jun 2019 10:04:38 -0700
From:   Eric Biggers <ebiggers@...nel.org>
To:     Herbert Xu <herbert@...dor.apana.org.au>
Cc:     Arnd Bergmann <arnd@...db.de>,
        "David S. Miller" <davem@...emloft.net>,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [v2] crypto: serpent - mark __serpent_setkey_sbox
 noinline

On Fri, Jun 28, 2019 at 12:19:12PM +0800, Herbert Xu wrote:
> On Tue, Jun 18, 2019 at 01:19:42PM +0200, Arnd Bergmann wrote:
> > The same bug that gcc hit in the past is apparently now showing
> > up with clang, which decides to inline __serpent_setkey_sbox:
> > 
> > crypto/serpent_generic.c:268:5: error: stack frame size of 2112 bytes in function '__serpent_setkey' [-Werror,-Wframe-larger-than=]
> > 
> > Marking it 'noinline' reduces the stack usage from 2112 bytes to
> > 192 and 96 bytes, respectively, and seems to generate more
> > useful object code.
> > 
> > Fixes: c871c10e4ea7 ("crypto: serpent - improve __serpent_setkey with UBSAN")
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > ---
> > v2: style improvements suggested by Eric Biggers
> > ---
> >  crypto/serpent_generic.c | 8 +++++++-
> >  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> Patch applied.  Thanks.
> -- 

Hi Herbert, seems you forgot to push?  I don't see this in cryptodev.

- Eric