[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CA+FuTSdL=GwjhbERsePAJfbakgEQZb7X51UHw=+4R9dJD3JD4A@mail.gmail.com>
Date: Fri, 28 Jun 2019 15:52:03 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Arnd Bergmann <arnd@...db.de>
Cc: Kees Cook <keescook@...omium.org>,
Larry Finger <Larry.Finger@...inger.net>,
Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
James Smart <james.smart@...adcom.com>,
Dick Kennedy <dick.kennedy@...adcom.com>,
"James E . J . Bottomley" <jejb@...ux.ibm.com>,
"Martin K . Petersen" <martin.petersen@...cle.com>,
"David S . Miller" <davem@...emloft.net>,
Wensong Zhang <wensong@...ux-vs.org>,
Simon Horman <horms@...ge.net.au>,
Julian Anastasov <ja@....bg>,
Pablo Neira Ayuso <pablo@...filter.org>,
James Morris <jmorris@...ei.org>, linux-scsi@...r.kernel.org,
linux-kernel <linux-kernel@...r.kernel.org>,
devel@...verdev.osuosl.org,
Network Development <netdev@...r.kernel.org>,
lvs-devel@...r.kernel.org,
netfilter-devel <netfilter-devel@...r.kernel.org>,
coreteam@...filter.org, Ard Biesheuvel <ard.biesheuvel@...aro.org>,
Nishka Dasgupta <nishkadg.linux@...il.com>
Subject: Re: [PATCH 3/4] staging: rtl8712: reduce stack usage, again
On Fri, Jun 28, 2019 at 8:41 AM Arnd Bergmann <arnd@...db.de> wrote:
>
> An earlier patch I sent reduced the stack usage enough to get
> below the warning limit, and I could show this was safe, but with
> GCC_PLUGIN_STRUCTLEAK_BYREF_ALL, it gets worse again because large stack
> variables in the same function no longer overlap:
>
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c: In function 'translate_scan.isra.2':
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c:322:1: error: the frame size of 1200 bytes is larger than 1024 bytes [-Werror=frame-larger-than=]
>
> Split out the largest two blocks in the affected function into two
> separate functions and mark those noinline_for_stack.
>
> Fixes: 8c5af16f7953 ("staging: rtl8712: reduce stack usage")
> Fixes: 81a56f6dcd20 ("gcc-plugins: structleak: Generalize to all variable types")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
Reviewed-by: Willem de Bruijn <willemb@...gle.com>
Powered by blists - more mailing lists