linux-kernel - RE: [EXT] [PATCH 73/87] ethernet: freescale: Remove memset after dma_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <VI1PR0402MB360017A5AA5A0E8470F44DE9FFFC0@VI1PR0402MB3600.eurprd04.prod.outlook.com>
Date:   Fri, 28 Jun 2019 02:26:48 +0000
From:   Andy Duan <fugang.duan@....com>
To:     Fuqian Huang <huangfq.daxian@...il.com>
CC:     "David S. Miller" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [EXT] [PATCH 73/87] ethernet: freescale: Remove memset after
 dma_alloc_coherent

From: Fuqian Huang <huangfq.daxian@...il.com> Sent: Friday, June 28, 2019 1:47 AM
> In commit af7ddd8a627c
> ("Merge tag 'dma-mapping-4.21' of
> git://git.infradead.org/users/hch/dma-mapping"),
> dma_alloc_coherent has already zeroed the memory.
> So memset is not needed.
> 
> Signed-off-by: Fuqian Huang <huangfq.daxian@...il.com>

Acked-by: Fugang Duan <fugang.duan@....com>
> ---
>  drivers/net/ethernet/freescale/fec_main.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/freescale/fec_main.c
> b/drivers/net/ethernet/freescale/fec_main.c
> index 38f10f7dcbc3..ec87b8b78d21 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -3143,8 +3143,6 @@ static int fec_enet_init(struct net_device *ndev)
>                 return -ENOMEM;
>         }
> 
> -       memset(cbd_base, 0, bd_size);
> -
>         /* Get the Ethernet address */
>         fec_get_mac(ndev);
>         /* make sure MAC we just acquired is programmed into the hw */
> --
> 2.11.0