[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CA+ASDXPyGECiq9gZmFj8TU6Gmt2epQtuBqnGqRWad79DJT589w@mail.gmail.com>
Date: Fri, 28 Jun 2019 15:58:49 -0700
From: Brian Norris <briannorris@...omium.org>
To: Sasha Levin <sashal@...nel.org>
Cc: Linux Kernel <linux-kernel@...r.kernel.org>,
stable <stable@...r.kernel.org>, Takashi Iwai <tiwai@...e.de>,
Kalle Valo <kvalo@...eaurora.org>,
linux-wireless <linux-wireless@...r.kernel.org>,
"<netdev@...r.kernel.org>" <netdev@...r.kernel.org>
Subject: Re: [PATCH AUTOSEL 4.19 14/60] mwifiex: Abort at too short BSS
descriptor element
On Wed, Jun 26, 2019 at 5:49 PM Sasha Levin <sashal@...nel.org> wrote:
>
> From: Takashi Iwai <tiwai@...e.de>
>
> [ Upstream commit 685c9b7750bfacd6fc1db50d86579980593b7869 ]
>
> Currently mwifiex_update_bss_desc_with_ie() implicitly assumes that
> the source descriptor entries contain the enough size for each type
> and performs copying without checking the source size. This may lead
> to read over boundary.
>
> Fix this by putting the source size check in appropriate places.
>
> Signed-off-by: Takashi Iwai <tiwai@...e.de>
> Signed-off-by: Kalle Valo <kvalo@...eaurora.org>
> Signed-off-by: Sasha Levin <sashal@...nel.org>
For the record, this fixup is still aiming for 5.2, correcting some
potential mistakes in this patch:
63d7ef36103d mwifiex: Don't abort on small, spec-compliant vendor IEs
So you might want to hold off a bit, and grab them both.
Brian
Powered by blists - more mailing lists