[<prev] [next>] [day] [month] [year] [list]
Message-Id: <20190628024952.15866-1-huangfq.daxian@gmail.com>
Date: Fri, 28 Jun 2019 10:49:49 +0800
From: Fuqian Huang <huangfq.daxian@...il.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Fuqian Huang <huangfq.daxian@...il.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Murray McAllister <murray.mcallister@...omniasec.com>,
Kimberly Brown <kimbrownkd@...il.com>,
Mamta Shukla <mamtashukla555@...il.com>,
Anirudh Rayabharam <anirudh.rayabharam@...il.com>,
Hardik Singh Rathore <hardiksingh.k@...il.com>,
Nishka Dasgupta <nishka.dasgupta@...oo.com>,
Arnd Bergmann <arnd@...db.de>,
Hans de Goede <hdegoede@...hat.com>,
Payal Kshirsagar <payal.s.kshirsagar.98@...il.com>,
Emanuel Bennici <benniciemanuel78@...il.com>,
devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: [PATCH v2 20/27] staging: rtl8723bs: remove unneeded memset
rtw_zmalloc already zeroes the memory,
so memset is unneeded.
Signed-off-by: Fuqian Huang <huangfq.daxian@...il.com>
---
drivers/staging/rtl8723bs/core/rtw_ap.c | 2 --
drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 --
2 files changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
index bc0230672457..dc1da5626ce1 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ap.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
@@ -1504,8 +1504,6 @@ static int rtw_ap_set_key(
goto exit;
}
- memset(psetkeyparm, 0, sizeof(struct setkey_parm));
-
psetkeyparm->keyid = (u8)keyid;
if (is_wep_enc(alg))
padapter->securitypriv.key_mask |= BIT(psetkeyparm->keyid);
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
index 5f78f1eaa7aa..3586da79af5a 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
@@ -2229,7 +2229,6 @@ sint rtw_set_auth(struct adapter *adapter, struct security_priv *psecuritypriv)
goto exit;
}
- memset(psetauthparm, 0, sizeof(struct setauth_parm));
psetauthparm->mode = (unsigned char)psecuritypriv->dot11AuthAlgrthm;
pcmd->cmdcode = _SetAuth_CMD_;
@@ -2262,7 +2261,6 @@ sint rtw_set_key(struct adapter *adapter, struct security_priv *psecuritypriv, s
res = _FAIL;
goto exit;
}
- memset(psetkeyparm, 0, sizeof(struct setkey_parm));
if (psecuritypriv->dot11AuthAlgrthm == dot11AuthAlgrthm_8021X) {
psetkeyparm->algorithm = (unsigned char)psecuritypriv->dot118021XGrpPrivacy;
--
2.11.0
Powered by blists - more mailing lists