lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 28 Jun 2019 11:01:16 +0800 From: Wen Yang <wen.yang99@....com.cn> To: linux-kernel@...r.kernel.org Cc: wang.yi59@....com.cn, Wen Yang <wen.yang99@....com.cn>, Benoit Parrot <bparrot@...com>, Mauro Carvalho Chehab <mchehab@...nel.org>, linux-media@...r.kernel.org Subject: [PATCH 3/3] media: ti-vpe: fix leaked of_node references The call to of_get_parent returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: drivers/media/platform/ti-vpe/cal.c:1621:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 1607, but without a corresponding object release within this function. Signed-off-by: Wen Yang <wen.yang99@....com.cn> Cc: Benoit Parrot <bparrot@...com> Cc: Mauro Carvalho Chehab <mchehab@...nel.org> Cc: linux-media@...r.kernel.org Cc: linux-kernel@...r.kernel.org --- drivers/media/platform/ti-vpe/cal.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/ti-vpe/cal.c b/drivers/media/platform/ti-vpe/cal.c index 9e86d761..8e19974 100644 --- a/drivers/media/platform/ti-vpe/cal.c +++ b/drivers/media/platform/ti-vpe/cal.c @@ -1613,6 +1613,7 @@ of_get_next_port(const struct device_node *parent, } prev = port; } while (!of_node_name_eq(port, "port")); + of_node_put(ports); } return port; -- 2.9.5
Powered by blists - more mailing lists